Skip to content

fix pg_rewind docs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: patches17
Choose a base branch
from
Open

Conversation

angaz
Copy link

@angaz angaz commented Dec 18, 2024

A previous commit, 73f1c62, added lines to the doc files which resulted in unclosed tags, which makes the docs build fail.

I think this is what the author meant to do.

I'm not sure if this is the right place to merge this commit.

akorotkov and others added 30 commits October 1, 2024 14:55
Discussion: https://postgr.es/m/CAPpHfdua-YFw3XTprfutzGp28xXLigFtzNbuFY8yPhqeq6X5kg%40mail.gmail.com
Reviewed-by: Aleksander Alekseev, Pavel Borisov, Vignesh C, Mason Sharp
Reviewed-by: Andres Freund, Chris Travers
Snapshot have two pairing heap nodes: for data and system undos.
 * Added SearchCatCacheInternal_hook, SearchCatCacheList_hook
 * Added SysCacheGetAttr_hook
IsFatalError()
have_backup_in_progress()
SnapBuildNextPhaseAt()
DoLocalLockExist()
Outline-atomics is a gcc compilation flag that enables runtime detection
of CPU support for atomic instructions.
Performance on CPUs that do support atomic instructions is improved,
while compatibility and performance on CPUs without atomic instructions
is not hurt.

Discussion: https://postgr.es/m/flat/099F69EE-51D3-4214-934A-1F28C0A1A7A7%40amazon.com
Author: Tsahi Zidenberg
They are allowed to stay during shutdown checkpointing and help checkpointer
do its work.
To use curl during shared_preload_libraries initialization.
- added option --extension for pg_rewind
- extracted SimpleXLogRead from extractPageMap for generic wal iteration in pg_rewind
homper and others added 26 commits October 1, 2024 23:12
Also validates compatability of index AM with table AM at index creation
Added xlogptr and xmin to determine right order of transactions when decoding on replica
 * Add xlogptr and xmin to determine right order of transactions when
   decoding on replica.
 * Add CSN snapshot data to snapshot builder.
 * Record CSN to the running xids and restore it during logical decoding
   to the snapshot builder.
 * Add function to update CSN snapshot data in snapshot builder.
 * Update CSN snapshot LSN in snapshot building after each transaction commit.
 * Restore CSN snapshot data in SnapBuildBuildSnapshot().
That allows S3 mode to finish WAL archiving if needed.
That allows to process flushed buffers in CheckPoint_hook().
Use GetIndexAmRoutineExtended instead for all Orioledb extensibility.
We split aminsert method to aminsert and aminsertextended.

aminsert is a method for indexes implemented in other extensions, it
accepts ItemPointer tupleid.

aminsertextended is for internal Postgres indexes and Orioledb, it
accepts Datum tupleid. They are not supposed to call aminsert method, so
that it is set NULL for them. We can not rely that extensions are aware
of aminsertextended, so index_insert() calls aminsert if it's not NULL
preferentially.

Signature of index_insert() is reverted so that it could be called by other
extensions. Datum tupleid is confined inside index_insert method.
Commit 5bf748b allows generation of unsafe SAOP path keys
on a multicolumn index that were disabled previously by 807a40c.
Replace "(indexkey op C1) OR (indexkey op C2) ... (indexkey op CN)" with
"indexkey op ANY(ARRAY[C1, C2, ...])" (ScalarArrayOpExpr node) during matching
a clause to index.

Here Ci is an i-th constant or parameters expression, 'expr' is non-constant
expression, 'op' is an operator which returns boolean result and has a commuter
(for the case of reverse order of constant and non-constant parts of the
expression, like 'Cn op expr').

This transformation allows handling long OR-clauses with single IndexScan
avoiding slower bitmap scans.

Discussion: https://postgr.es/m/567ED6CA.2040504%40sigaev.ru
Author: Alena Rybakina <[email protected]>
Author: Andrey Lepikhov <[email protected]>
Reviewed-by: Peter Geoghegan <[email protected]>
Reviewed-by: Ranier Vilela <[email protected]>
Reviewed-by: Alexander Korotkov <[email protected]>
Reviewed-by: Robert Haas <[email protected]>
Reviewed-by: Jian He <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Reviewed-by: Nikolay Shaplov <[email protected]>
When optimizer generates bitmap paths, it considers breaking OR-clause
arguments one-by-one.  But now, a group of similar OR-clauses can be
transformed into SAOP during index matching.  So, bitmap paths should
keep up.

This commit teaches bitmap paths generation machinery to group similar
OR-clauses into dedicated RestrictInfos.  Those RestrictInfos are considered
both to match index as a whole (as SAOP), or to match as a set of individual
OR-clause argument one-by-one (the old way).

Therefore, bitmap path generation will takes advantage of OR-clauses to SAOP's
transformation.  The old way of handling them is also considered.  So, there
shouldn't be planning regression.

Discussion: https://postgr.es/m/567ED6CA.2040504%40sigaev.ru
Reviewed-by: Alexander Korotkov <[email protected]>
An operation like '12:34:56'::time_tz takes the UTC offset from
the prevailing time zone, which means that the results change
across DST transitions.  One of the test cases added in ed055d249
failed to consider this.

Per report from Bernhard Wiedemann.  Back-patch to v17, as the
test case was.

Discussion: https://postgr.es/m/[email protected]
Obviously, the constant could be zero.  Also, add the relevant check to
regression tests.

Reported-by: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4-siKJdtWhcbqk4Y-xG12do2Ckm1qw672GNsSnDqL9FQg%40mail.gmail.com
…SAOP

There is no point in transforming OR-clauses into SAOP's if the target index
doesn't support SAOP scans anyway.  This commit adds corresponding checks
to match_orclause_to_indexcol() and group_similar_or_args().  The first check
fixes the actual bug, while the second just saves some cycles.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/8174de69-9e1a-0827-0e81-ef97f56a5939%40gmail.com
Author: Alena Rybakina
Reviewed-by: Ranier Vilela, Alexander Korotkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants